Properly fall back to potentials and avoid violating targets - #7380
Open
vkip wants to merge 2 commits into
Open
Conversation
…argets in case of zero potentials.
vkip
added
the
manual:bugfix
Member
Author
|
jenkins build this opm-common=5329 please |
Member
Author
|
jenkins build this opm-common=5329 please |
vkip
marked this pull request as ready for review
September 1, 2026 12:21
Member
|
Thanks. Based on reading the code and description. The issue it fixes seems both real and the fix adequate. Do you have a small test case that exposes this that we can add for regression? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Together with OPM/opm-common#5329, ensures consistent results between using potentials only and GUIDERAT (A=1,B=1,C=D=E=F=0) + WGRUPCON with guiderate defaulted. Also fixes a target violation issue for the latter case.